slash/slash-desktop
2
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: afterpack.js hardcoded Mattermost.exe/.app breaks Windows/macOS builds #4

Merged
mohlec merged 1 commit from fix/afterpack-branding into slash/main 2026-07-07 14:35:22 +00:00
Conversation 0 Commits 1 Files changed 1 +8 -2
mohlec commented 2026-07-07 14:30:39 +00:00
Owner
Copy link

build-windows (PR #3, both the branch run and the post-merge run on real CI) fails with:

afterPack error:  [Error: ENOENT: no such file or directory, open .../release/win-unpacked/Mattermost.exe]

getAppFileName() in scripts/afterpack.js hardcoded the upstream Mattermost.exe/.app names instead of deriving them from the actual (rebranded) productName, unlike the linux case which already did this correctly via context.packager.executableName. Same fix applied to win32/darwin.

Not a branding-audit gap — check-branding.sh is deliberately scoped to user-visible i18n strings, not build tooling; this is a functional bug, not a trademark issue.

build-windows (PR #3, both the branch run and the post-merge run on real CI) fails with: ``` afterPack error: [Error: ENOENT: no such file or directory, open .../release/win-unpacked/Mattermost.exe] ``` getAppFileName() in scripts/afterpack.js hardcoded the upstream Mattermost.exe/.app names instead of deriving them from the actual (rebranded) productName, unlike the linux case which already did this correctly via context.packager.executableName. Same fix applied to win32/darwin. Not a branding-audit gap — check-branding.sh is deliberately scoped to user-visible i18n strings, not build tooling; this is a functional bug, not a trademark issue.
fix: afterpack.js hardcoded Mattermost.exe/.app breaks Windows/macOS packaging
Some checks failed
Build Slash Desktop / build-macos (pull_request) Has been skipped
Details
Build Slash Desktop / build-windows (pull_request) Failing after 57s
Details
Build Slash Desktop / build-linux (pull_request) Successful in 6m0s
Details
ff6b3d1a76 
Leftover from the original mattermost/desktop fork: getAppFileName()
hardcoded 'Mattermost.exe' (win32) and 'Mattermost.app' (darwin), but the
app was rebranded (productName: 'Slash' in package.json), so
electron-builder produces a differently-named binary and afterPack's
electron/fuses step can't find it:

  afterPack error: ENOENT: no such file or directory, open
  '.../release/win-unpacked/Mattermost.exe'

This broke build-windows (confirmed failing on PR #3's branch run and
again on the post-merge run, both on real CI) and would have broken
build-macos identically whenever that job gets a runner. linux never hit
this because it already derived the filename dynamically via
context.packager.executableName — win32/darwin now do the same instead of
using stale literals.

Not a branding-audit gap: check-branding.sh is deliberately scoped to
user-visible i18n string values (see its own header comment), not build
tooling — this is a functional correctness bug, not a trademark issue.
mohlec merged commit ede265f9b5 into slash/main 2026-07-07 14:35:22 +00:00
mohlec deleted branch fix/afterpack-branding 2026-07-07 14:35:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
slash/slash-desktop!4
No description provided.